Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a button to "Query Info" of every download in the list #1861

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Deewens
Copy link

@Deewens Deewens commented Sep 3, 2023

I added a button next to the "Refresh" button in the downloads tab to directly query the info of every download in the list. I feel like that's a simple feature to add, and it is really useful for people with a huge mod list to retrieve info from.

I also know people would like to see this feature in MO2 (#1180), and also some post on Reddit.

I know it is considered a duplicate of this: #725
But this one is much more complex to implement, requiring too much rewriting for me, as I am only a first time contributor and I don't have a sufficient knowledge of the codebase. I don't mind trying to undertake #725, however, but for now, I feel like simple button could already be useful and also a really needed feature!

ModOrganizer_6fobRj02Qk

I think the Icon needs to be changed to something not that close to the "Refresh" button. Also, I only tested to Query Info on 103 downloads (fallout mods if that's important). I don't know how it will react if there is an error during the process.

I haven't found any guideline to follow to code and create my PR, so I hope it's fine!

@Holt59
Copy link
Member

Holt59 commented Sep 22, 2023

Thanks for the PR. This will probably conflict a lot with the other download PR, so we will probably wait to merge this since it should be easier for you to rebase on the other PR than the other way around.

In the meantime, you should 1) apply clang format to fix the lint CI and 2) remove the .ts file from commits.

@Deewens
Copy link
Author

Deewens commented Oct 29, 2023

Thanks for the PR. This will probably conflict a lot with the other download PR, so we will probably wait to merge this since it should be easier for you to rebase on the other PR than the other way around.

In the meantime, you should 1) apply clang format to fix the lint CI and 2) remove the .ts file from commits.

Hi, thanks, I haven't seen your reply earlier. I will fix the format and remove the .ts. Where is the other PR? Has it already been merged?

@Silarn
Copy link
Member

Silarn commented Nov 9, 2023

That PR has been closed for the time being. At this point this change would likely go into a 2.5.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants